What is wrong with it?

Forum Attachments

Summary:

This thread is for people that need a fresh set of eyes to find something wrong with a program

What is wrong with it?

TheCubist 04 Dec 2016 05:50

Ok, when I run this (its a pong program if you couldnt figure that out) the "ball" stays in the middle of the screen. I have it turn the pixel on at Z,X and it adds 2 or subtracts 2 to X to move it from one side to the other. it still lets me move my paddle around, so it is going through the program. Im thinking the ball is bouncing back and fourth between two spots, but I don't see how it would happen. Thanks for checking it out! (P.S, this is not done yet, and any advice is helpful

Lbl 1
ClrHome
32→A
32→B
0→S
48→X
32→Z
0→N
­2→M
Disp "Welcome to PONG","1: No Friends","2: Two Player"
Repeat sum(J={92,93,45
getKey→J
End
If J=45
Stop
DispGraph
AxesOff
FnOff 
While 1
X+M→X
Z+N→Z
Pxl-On(Z,X
getKey→K
If K
Then
If K=21
Then
If A≠6
Then
A-1→A
Pxl-Off(A+6,3
Pxl-On(A-5,3
Pxl-On(A+4,3
End
End
If K=31
Then
If A≠56
Then
A+1→A
Pxl-On(A-4,3
Pxl-On(A+5,3
Pxl-Off(A-6,3
End
End
If J=93
Then
If K=25
Then
If B≠6
Then
B-1→B
Pxl-Off(B+6,90
Pxl-On(B+4,90
Pxl-On(B-5,90
End
End
If K=34
Then
If B≠56
Then
B+1→B
Pxl-On(B-4,90
Pxl-On(B+5,90
Pxl-Off(B-6,90
End
End
End
End
If Z>58 or Z<5
­N→N
If sum(X={3,4
Then
If sum(Z={A-1,A-2,A-3,A-4,A-5,A+1,A+2,A+3,A+4,A+5
Then
­M→M
A-Z→N
S+1→S
ClrHome
End
If Z=A
randInt(-5,5)→N
End
If J=93
Then
If sum(X={89,90
Then
If sum(Z={B+1,B+2,B+3,B+4,B+5,B-1,B-2,B-3,B-4,B-5
Then
B-Z→N
­M→M
ClrHome
End
If Z=B
randInt(-5,5)→N
End
End
If J=93 and sum(X={3,4}) and not(sum(Z={A,A-1,A-2,A-3,A-4,A-5,A+1,A+2,A+3,A+4,A+5
Goto L
If J=93 and sum(X={90,89}) and not(sum(Z={B,B+1,B+2,B+3,B+4,B+5,B-1,B-2,B-3,B-4,B-5
Goto L
If J=92 and sum({X=90,89
­M→M
Goto A
If J=92 and sum(X={3,4}) and not(sum(Z={A,A-1,A-2,A-3,A-4,A-5,A+1,A+2,A+3,A+4,A+5
Disp "YOU SUCK!","1: Play Again?","2: Quit
Lbl L
If J=93 and sum(X={3,4
Disp "RIGHT WINS!","1: Play Again?","2: Quit
If J=93 and sum(x={89,90
Disp "LEFT WINS!","1: Play Again?","2: Quit
Repeat sum(L={92,93,45
getKey→L
End
If L=92
Return
If sum(L={93,45
Stop
Lbl A
If J=92
Text(1,48,S
End
Goto 1

Re: What is wrong with it?

Trenly 04 Dec 2016 06:55

I found a small optimization, but I didn't look for what was causing your error.

If sum(X={3,4
Then
If sum(Z={A-1,A-2,A-3,A-4,A-5,A+1,A+2,A+3,A+4,A+5
Then
­M→M
A-Z→N
S+1→S
ClrHome
End
If Z=A
randInt(-5,5)→N
End
If J=93
Then
If sum(X={89,90
Then
If sum(Z={B+1,B+2,B+3,B+4,B+5,B-1,B-2,B-3,B-4,B-5
Then
B-Z→N
­M→M
ClrHome
End
If Z=B
randInt(-5,5)→N
End
End
If J=93 and sum(X={3,4}) and not(sum(Z={A,A-1,A-2,A-3,A-4,A-5,A+1,A+2,A+3,A+4,A+5
Goto L
If J=93 and sum(X={90,89}) and not(sum(Z={B,B+1,B+2,B+3,B+4,B+5,B-1,B-2,B-3,B-4,B-5
Goto L
If J=92 and sum({X=90,89
­M→M
Goto A
If J=92 and sum(X={3,4}) and not(sum(Z={A,A-1,A-2,A-3,A-4,A-5,A+1,A+2,A+3,A+4,A+5
Disp "YOU SUCK!","1: Play Again?","2: Quit

Space saving version:

{-1,-2,-3,-4,-5,0,1,2,3,4,5->L1

­N→N
If sum(X={3,4
Then
If sum(Z={A+L1
Then
­M→M
A-Z→N
S+1→S
ClrHome
End
If Z=A
randInt(-5,5)→N
End
If J=93
Then
If sum(X={89,90
Then
If sum(Z={B+L1
Then
B-Z→N
­M→M
ClrHome
End
If Z=B
randInt(-5,5)→N
End
End
If J=93 and sum(X={3,4}) and not(sum(Z={A+L1
Goto L
If J=93 and sum(X={90,89}) and not(sum(Z={B+L1
Goto L
If J=92 and sum({X=90,89                                                      //Maybe an error is here? you store M to M but since you have no "Then", "Goto A" will always be executed
­M→M
Goto A
If J=92 and sum(X={3,4}) and not(sum(Z={A+L1
Disp "YOU SUCK!","1: Play Again?","2: Quit

NICE!

TheCubist 04 Dec 2016 18:01

Oh sweet! didn't even think about that optimization. And i do want the program to always go to A if it doesnt go to L, but i do need to move the segment directly above the Lbl L above the goto. Thanks for noticing that, still don't think thats going to be the issue. A possible issue may be that it is getting to final end, and its not corresponding to the while at the top. But I have looked at it like 20 times over, and im pretty sure that the last end applies to the while. thanks for the help!
EDIT: Wait, that can't be right. otherwise it would show the menu each time….
EDIT: OMG! When i copied and pasted, it didnt do the negative signs. whereever there is a M->M, its actually -M->M

Last edited on 04 Dec 2016 18:04 by TheCubist Show more

Some Person (guest) 12 Apr 2017 17:46

This program does not work when I run it. (It's a program that displays the phenotypes through Mendelian genetics). Any suggestions?
Output(1,1,"1.AA 2.HYBRID 3.LAA")
Pause
ClrHome
Output(2,1,"NUMBER OF GENERATIONS (AFTER P GENERATION!)")
Prompt A
ClrHome
Output(2,1,"SAMPLE NUMBER(EVENS!)")
Prompt X
0→B
ClrList L₂
ClrList L₁
While B≤(X-1)
2→L₁(B+1)
B+1→B
End
0→F
Lbl 1
While F≤(A-1)
rand(X)→L₄
seq(X,X,1,X→L₂
SortA(L₄,L₂
DelVar L₄
0→B
While B≤(X-2)
L₂(B+1)→C
L₂(B+2)→D
If (L₁(C))(L₁(D))=1
Then
1→L₁(C)
1→L₁(D)
End
If (L₁(C))(L₁(D))=9
Then
3→L₁(C)
3→L₁(D)
End
If (L₁(C))(L₁(D))=3
Then
2→L₁(C)
2→L₁(D)
End
If (L₁(C))(L₁(D))=2
Then
randInt(1,4,2)→L₃
End
If L₃(1)+L₃(1)=4 and (L₁(C))(L₁(D))=2
Then
1→L₁(C)
Else
2→L₁(C)
End
If L₃(2)+L₃(2)=4 and (L₁(C))(L₁(D))=2
Then
1→L₁(D)
Else
2→L₁(D)
End
If (L₁(C))(L₁(D))=6
Then
randInt(1,4,2)→L₃
End
If L₃(1)+L₃(1)=3 and (L₁(C))(L₁(D))=6
Then
2→L₁(C)
Else
3→L₁(C)
End
If L₃(2)+L₃(2)=3 and (L₁(C))(L₁(D))=6
Then
2→L₁(D)
Else
3→L₁(D)
End
If (L₁(C))(L₁(D))=4
Then
randInt(1,4,2)→L₃
End
If L₃(1)=1 and (L₁(C))(L₁(D))=4
Then
1→L₁(C)
End
If L₃(2)=1 and (L₁(C))(L₁(D))=4
Then
1→L₁(D)
End
If L₃(1)+L₃(1)=5 and (L₁(C))(L₁(D))=4
Then
2→L₁(C)
End
If L₃(2)+L₃(2)=5 and (L₁(C))(L₁(D))=4
Then
2→L₁(D)
End
If L₃(1)=4 and (L₁(C))(L₁(D))=4
Then
3→L₁(C)
End
If L₃(2)=4 and (L₁(C))(L₁(D))=4
3→L₁(D)
End
B+2→B
End
F+1→F
Output(1,1,"PHENOTYPE")
Output(2,1,L₁)
Output(1,24,F)
End
If F≤(A-1)
Then
Goto 1
End

Battlesquid 12 Apr 2017 18:32

What errors are you receiving?

---

Some Person (guest) 12 Apr 2017 21:13

It is like as if it is in a pause/ stasis when I run it. This is after the inputs I added in.

Myles_Zadok 12 Apr 2017 22:18

It may be that while the conditional

:If F≤(A-1)

is true, the program loops infinitely, which may be why it appears to be in a stasis state.

Some Person (guest) 13 Apr 2017 00:38

Alright, I moved the F+1-> F after the while loop. The program is no longer in stasis! BUT now the list that is supposed to be displayed is all threes. (Supposed to be roughly a 25% 1 50% 2 25% 3). This program is plagued with errors.

Re: What is wrong with it?

TheCubist 21 Oct 2017 00:22

Made a program to find all the prime factors of a number. My teacher already had one, but he wanted to see if I could make one. So, i put together this:
ClrHome
0→X
ClrList L₁
Input "Value:",T
Repeat N>√(T
2→N
While fPart(T/N) and N≤√(T
(N+1)→N
End
X+1→X
N→L₁(X
T/N→T
End
If N=2
Then
T→L₁(X
2→L₁(X+1
Else
T*N→L₁(X
End
Disp L₁

Try running it if you like, it works well for small numbers. But, I started checking some bigger numbers, and the number 16894343 has a factor (719) but it doesn't find it. I asked my teacher to run his program, and it found it! I don't know where I went wrong but if someone could let me know what is up, that would be awesome. Thanks

Re: What is wrong with it?

Myles_Zadok 21 Oct 2017 00:35

Two things:

1: This post has nothing to do with this dead thread. If you have a new topic, you should create a new thread.

2: This page has a very optimized routine for finding the prime factors of a number.

Re: What is wrong with it?

TheCubist 21 Oct 2017 00:54

The forums say specifically to not create a new thread if there is one that already fits… And this does have to do with this thread I'm asking what is wrong with the program… Thanks for the link to the page though :)

Re: What is wrong with it?

Trenly 21 Oct 2017 01:17

Please enlighten me as to where it says to not create a new thread if there is one that already fits? I see nothing about it in our rules.

I will also have to agree with Myles_Zadok that your post was not relevant since the initial post was about a pong game that was not working and is not about any code that is not working.

Last edited on 21 Oct 2017 01:19 by Trenly Show more

Re: What is wrong with it?

Myles_Zadok 21 Oct 2017 01:22

From the Rules page, section Forum Rules:

Don't reply to old threads (last post is more than three months old); start a new thread instead.

The last post was in April, 6 months ago, which makes this necroposting—posting on a dead thread. Also, I do not see anything on the Forums page that says not to create a new thread if there is one that already fits. For future reference, try to create a new thread when you have a new topic. Anyway, I'm glad that the routine helped you :P

EDIT: Trenly, okay, I'm glad I'm not the only who couldn't find anything about "don't create a new thread if there is one that already fits." I was worried that it was just me who didn't see that.

Last edited on 21 Oct 2017 01:25 by Myles_Zadok Show more

Re: What is wrong with it?

Battlesquid 21 Oct 2017 02:02

The summary states:

This thread is for people that need a fresh set of eyes to find something wrong with a program

The title states:

What is wrong with it?

TheCubist stated:

And this does have to do with this thread I'm asking what is wrong with the program

So there was no specific program this thread was intended for, it was just a help thread for him (and other users).

I do see that this is nearly over a year old, but the topic is on point. For example, I wouldn't create another thread for this topic because the content I put in it is relevant to the thread (as with this thread).

I think TheCubist is good…

---

Last edited on 21 Oct 2017 02:06 by Battlesquid Show more

Re: What is wrong with it?

Myles_Zadok 21 Oct 2017 02:23

The problem I have though is that people will keep posting in this thread and the thread will become so large that it will be difficult to find anything in here. Remember the incredibly large threads Thel Vadamee used to make? Or even the old Search Help threads? I don't want this thread (or any thread) becoming like one of those. It is easier all the way around if a new (even if only slightly different) topic has its own thread. I don't want people having their own personal threads, which is what this basically seems to be (except for the one guest who posted a question here). TheCubist didn't necessarily do anything wrong, as he may not have known the Rules. I was only trying to point out for future reference that it is usually deprecated to post a new topic in a "dead" thread. I hope I didn't come across as rude or offensive. :|

Re: What is wrong with it?

Battlesquid 21 Oct 2017 02:58

Rude? Pshhhhh, no :P

I remember those threads, and I think the problem was the forum-nesting. A linear nesting format makes things more readable, which I think is the reason large threads on these forums are hard to keep up with.

I think as long as the content is relative, it should be good (because with many people "life happens", and they may not be able to keep up to date with a project, but have no intentions of stopping it).

PS: Those threads were nothing. Here's a 2-year-old project thread still in the making :P

---

Last edited on 21 Oct 2017 03:00 by Battlesquid Show more